search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
259 stars 664 forks source link

refractor: Migration of update password screen to compose #2564

Closed itsPronay closed 3 months ago

itsPronay commented 3 months ago

fixes : #2561

Compose image

screen recording - Screencast_04_07_2024_04:29:57_AM.webm

AvneetSingh2001 commented 3 months ago

@itsPronay can you please edit your commit message to follow the commit guidelines.
Also ideally we should implement the whole screen in compose, So please make use of Topbar and ProgressIndicator of Compose rather than using the old way.

itsPronay commented 3 months ago

@AvneetSingh2001 Okay!

itsPronay commented 3 months ago

@AvneetSingh2001 Please take a look at my code and let me know if I should make any changes in it

AvneetSingh2001 commented 3 months ago

I see you still have not used compose progress indicator. Also you need to collect the flows as state in the compose itself. please go through my recent PR for the reference. Also me are aiming to eradicate fragments in the future, so migrate code in such a way that fragments should only be use return compose view.

itsPronay commented 3 months ago

@AvneetSingh2001 Okay bro! thanks for reviewing. I will make the necessary changes ASAP

itsPronay commented 3 months ago

I am really sorry. I have to close this one as it created conflicts + my git is now pretty messed up right now. I will be raising a new PR. Sorry about that...