openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
259 stars 664 forks source link

migrate transfer process screen to compose screen #2583 #2585

Closed Saifuddin53 closed 1 month ago

Saifuddin53 commented 2 months ago

Fixes #2583

Please Add Screenshots If there are any UI changes.

Before :

before

After :

after

Videos:

https://github.com/openMF/mifos-mobile/assets/112172255/32038de8-df5f-4e34-a992-59746c845eb5

AvneetSingh2001 commented 2 months ago

@Saifuddin53 requested some change, please update the code accordingly. Also can you please add screen recording as well

AvneetSingh2001 commented 2 months ago

@Saifuddin53 , can you check why are we getting HTTP 400 response for this?

Saifuddin53 commented 2 months ago

I think it's a server side error

AvneetSingh2001 commented 2 months ago

can you paste the logs about the error here

Saifuddin53 commented 2 months ago
Screenshot 2024-05-15 084635
Saifuddin53 commented 2 months ago

The same error is coming in our view-based screen. It would be solved when we migrate our previous screen which is SavingsMakeTransferFragment as it is passing null for the payto and payfrom fields

Saifuddin53 commented 2 months ago

https://github.com/openMF/mifos-mobile/assets/112172255/5df044c6-40c2-4fa7-93b6-b8301b0f8dc5

Saifuddin53 commented 2 months ago
Screenshot 2024-05-15 214738

@AvneetSingh2001 here the showSavingsAccountTemplate function is not able to fetch the accounts from the AccountOptions list

Saifuddin53 commented 1 month ago

@AvneetSingh2001 can you please review it again

itsPronay commented 1 month ago

@Saifuddin53 I see you have multiple commits. Please squash them

itsPronay commented 1 month ago

also please reformat your code, I believe it's ctrl + alt + L