openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
281 stars 691 forks source link

Transfer Exception : Repayment date cannot be on a non working day #441

Open therajanmaurya opened 7 years ago

therajanmaurya commented 7 years ago

Summary:

I was making normal transfer between savings account and I got the exception from server that Repayment date cannot be on a non working day. I don't think this is a valid exception because self-service is end-user application and user can do any transaction at any time that's the meaning of this app.

{
  "developerMessage": "Request was understood but caused a domain rule violation.",
  "httpStatusCode": "403",
  "defaultUserMessage": "Errors contain reason for domain rule violation.",
  "userMessageGlobalisationCode": "validation.msg.domain.rule.violation",
  "errors": [
    {
      "developerMessage": "Repayment date cannot be on a non working day",
      "defaultUserMessage": "Repayment date cannot be on a non working day",
      "userMessageGlobalisationCode": "error.msg.loan.application.repayment.date.on.non.working.day",
      "parameterName": "id",
      "value": null,
      "args": [
        {
          "value": [
            2017,
            10,
            8
          ]
        }
      ]
    }
  ]
}

@nazeer1100126 @edcable What do you think.

luckyman20 commented 7 years ago

@therajanmaurya I think you're right. This error is valid for only offline transfers. Online transfers can be made on any day. And In this we are making online transactions only.

therajanmaurya commented 7 years ago

yes @luckyman000786 you are right, BTW we are building end user bank application so there is nothing like offline transaction, everything will happen in real time.

edcable commented 7 years ago

@therajanmaurya let me have @nazeer1100126 or @santoshmath comment as you are correct this validation shouldn't be in place given it's not staff in an office initiating repayment transactions. We'll have to discuss how we can have this validation in place for transactions via web app but not through self-service channels. Can you start a thread on Apache Fineract dev list to publicly discuss this?

santoshconflux commented 7 years ago

Discussed with @nazeer1100126 and We too believe that the self service user must be allowed to do transactions on non-working days but it should not allow for office staff (users) if non-working days is configured.

santoshconflux commented 7 years ago

@therajanmaurya , Once you create the thread for the discussion as Ed suggested, please share the link.