search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
274 stars 686 forks source link

Remove "None" from Filter accounts Dialog #466

Closed dilpreet2028 closed 6 years ago

dilpreet2028 commented 7 years ago

Summary:

Filter Dialog for Savings, Loans and Sharing Accounts now has the option to Clear Filters so None option should be removed from the list.

Remove None from all the lists given in StatusUtils class and logic for checking None in Accounts Presenter class

Steps to reproduce:

Go to Accounts -> Click on top right most icon (3 bars) to see the filter dialog .

batbrain7 commented 6 years ago

@dilpreet96 may I send a PR for this?

luckyman20 commented 6 years ago

@batbrain7 Are you participating in this year's GCI?

batbrain7 commented 6 years ago

@luckyman000786 for next year's gsoc perhaps

luckyman20 commented 6 years ago

@batbrain7 Sorry, this issue is only available for GCI students as of now

mofetej commented 6 years ago

Hello, I claimed this tasked how do i submit. should i create a PR