search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
274 stars 686 forks source link

Clicking on Add beneficiary fab button should open new activity instead of fragment replacement #722

Closed AkshGautam closed 6 years ago

AkshGautam commented 6 years ago

Summary:

As suggested by @therajanmaurya in the PR https://github.com/openMF/mifos-mobile/pull/705 comments that clicking the fab button while adding beneficiary should open a new activity instead of fragment replace.

I am working on it.

AkshGautam commented 6 years ago

@therajanmaurya Why do we need a new activity instead of the fragment replacement? As an android developer, how do we make the tradeoff between a new activity or a fragment? I went through the https://stackoverflow.com/questions/20306091/dilemma-when-to-use-fragments-vs-activities post and it had several viewpoints. what do you think,which one to use when?

PS: I would like to work on this task

therajanmaurya commented 6 years ago

@AkshGautam because of UX.

therajanmaurya commented 6 years ago

Go ahead and send PR.