search

openMF / mifos-mobile

Repository for the Mifos Mobile Banking App for clients
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
274 stars 686 forks source link

Entities in spinner are being displayed multiple times, when submit beneficiary button pressed in 'Add Beneficiary' fragment #883

Open drish1001 opened 6 years ago

drish1001 commented 6 years ago

Summary On going into the Benefeciaries, from the homepage and on adding new beficiaries, a try again page is being displayed, which on retrying, results in display of same entities in the spinner.

Steps to reproduce:

  1. Go to the Beneficiaries.
  2. Click in the FAB Button.
  3. Click on Add in Select Mode
  4. Enter the necessary details and click on Submit Beneficiary.
  5. Click on Try again. (When unable to create beneficiaries.)
  6. Tap on the Select Account Type spinner

Expected behaviour:

Same entities shouldn't be displayed multiple times.

Observed behaviour:

Same entites are displayed multiple times, on the spinner.

Device and Android version:

Redmi Note 5 Pro (WHYRED) MIUI Global 9.6 Android Oreo 8.1.0

GIF ezgif com-resize

drish1001 commented 6 years ago

May I please work on this issue?

miPlodder commented 6 years ago

@drish1001 The reason you are not able to create Beneficiary is that you are giving the wrong Credentials. Choose a valid Account Number and Office Number. For example,

Account Number = 000000001 Office Number = Head Office

Rest information can be anything.

Although, the behaviour for wrong credentials is wrong. You can work on it.

drish1001 commented 6 years ago

Can you please review this pull request?

nirmalhk7 commented 4 years ago

Since #887 has been closed by @therajanmaurya , can I work on this issue?