search

openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.
https://openmf.github.io/web-app/
Mozilla Public License 2.0
226 stars 511 forks source link

Replace multiselect by custom checkbox tree in create holiday component #1231

Closed karantakalkar closed 2 years ago

karantakalkar commented 4 years ago

Screenshot from 2020-08-27 18-59-04

We need to use custom made angular material checkbox tree, refer to view tree implementations in accounting section and angular material checkbox tree implementation https://material.angular.io/components/tree/examples and develop a custom solution that fits fineract APIs as well as our use case

zerefwayne commented 4 years ago

Can I work on this?

karantakalkar commented 4 years ago

Go ahead, please

Abhirup-99 commented 3 years ago

@karantakalkar can I work on this issue? It seems to be inactive for a long time.

karantakalkar commented 3 years ago

There is an PR on this issue ask the author

Abhirup-99 commented 3 years ago

@zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?

zerefwayne commented 3 years ago

Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it.

On Thu, 8 Oct 2020, 22:21 Abhirup Pal, notifications@github.com wrote:

@zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openMF/web-app/issues/1231#issuecomment-705695631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .

Abhirup-99 commented 3 years ago

Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it. … On Thu, 8 Oct 2020, 22:21 Abhirup Pal, @.***> wrote: @zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1231 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .

Ok cool. Thanks.

Abhirup-99 commented 3 years ago

Since the previous pr is closed now, can I go forward with this issue? @karantakalkar

Abhirup-99 commented 3 years ago

I was working on this issue, should I improve upon the work done in the previous pr or create a completely new one? @karantakalkar

ramvr1256 commented 2 years ago

Added feature. Working as Expected.