openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.
https://openmf.github.io/web-app/
Mozilla Public License 2.0
227 stars 511 forks source link

Activation button of holiday is not working #1315

Closed bharathcgowda closed 3 years ago

bharathcgowda commented 3 years ago

Description

when we create a holiday, we have to activate it, but the Activation button is not working

Steps to Reproduce

  1. go to admin->organization->manage holidays
  2. create a holiday
  3. try to activate the holiday

Expected Behaviour

activate button should activate the created holiday

Screenshots, if any

image

samerdar123 commented 3 years ago

Is the expected functionality just to have the activate button to have a little lock signal and for the holiday to have an activated status on the user's end? Or is there something else that should be happening upon activation? image

bharathcgowda commented 3 years ago

Holidays that are activated only will affect the schedules of loans. in other words, holidays are created to shift the payments and installments which fall on those days, system will do that for holidays that are activated, and not for "pending for activation" status.

clicking on Activate button should internally call the API https://DomainName/api/v1/holidays/{holidayId}?command=activate from where the fineract will take care(as the backend is completely functional in this module) you can explore the API and parameters in the API doc https://demo.mifos.io/api-docs/apiLive.htm

gustavao commented 3 years ago

Hi, I found the problem adding the request in the service. I've sent pull request https://github.com/openMF/web-app/pull/1345 greetings!

bharathcgowda commented 3 years ago

issue fixed.