search

openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.
https://openmf.github.io/web-app/
Mozilla Public License 2.0
226 stars 511 forks source link

Trache Addition screen for Loan account issue #1442

Closed bharathcgowda closed 2 years ago

bharathcgowda commented 2 years ago

Description

for a loan account with tranche enabled, the "loan tranche details tab" should just have a + sign to add the tranche and not the tranche addition row by default.

Now image

Example screen from community-app image

ramvr1256 commented 2 years ago

I added this row because a tranche-enabled loan account can not be submitted without any entry as you can try this on default.ps.mifos.io. At least one entry is needed to submit a loan application. Do you still want to remove this row? This may lead users not identify the cause of not submitting. Currently, they can at least they will be prompted to fill this required field.

bharathcgowda commented 2 years ago

@ramvr1256 There is a configuration that enables users to do multi-disbursements without adding a tranche, there is no UI yet for this configuration but is being used by some of the organizations. this change is affecting the loan creations for such products, let's revert as discussed in this ticket.

You can refer to this PR for more details as well https://github.com/apache/fineract/commit/bd8dab19467841e4a26cdf0f47b31085702cd980

ramvr1256 commented 2 years ago

Okay, sure. I will change this. Thanks for the clarification.

bharathcgowda commented 2 years ago

fixed