openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.
https://openmf.github.io/web-app/
Mozilla Public License 2.0
226 stars 511 forks source link

View charge page does not show minimum and maximum charge cap values #1923

Closed jogathogo closed 8 months ago

jogathogo commented 9 months ago

Description

When creating a charge there are options to set the minimum and maximum values. Once the charge has been created, these two values are not displayed.

Steps to Reproduce

Go to Admin/Products/Charges Select applies to savings Screenshot 2023-12-08 at 09 14 25

Fill the other fields making sure to set the min and max values Submit

Once the fee has been created, open the fee and note the min/max values are not shown

Expected Behaviour

Min and Max values should be displayed on the view fee page

Actual Behaviour

Min and max values are not displayed Screenshot 2023-12-08 at 09 20 33

Settings

Screenshots, if any

Gmin2 commented 9 months ago

can i work on it?

jogathogo commented 9 months ago

Please do

Gmin2 commented 9 months ago

Can You assign this to me

jogathogo commented 9 months ago

@edcable @bharathcgowda please assign this issue to @Min2who

PC-11-00 commented 9 months ago

@Min2who you can work on this issue, I have assigned you

PC-11-00 commented 9 months ago

@jogathogo From backend API Response,no min-cap and max-cap are coming

bharathcgowda commented 9 months ago

@PC-11-00 thanks for looking into this. the backend ticket is here for the same https://issues.apache.org/jira/browse/FINERACT-2033

bharathcgowda commented 8 months ago

@PC-11-00 The developer worked on the backed issue raised and here is the observation on the same

The Mincap and Maxcap are allowed for Loan entity

Savings Entity

SHARE_PURCHASE and SHARE_REDEEM % amount can be defined and min max values can be saved

Since mincap and maxcap are available in the Get API When these values are selected .

So we will have to do the following

  1. Enable mincap and maxcap fields only when the above parameters are selected.
  2. Display mincap and maxcap fields that are coming in the Get API
  3. In Edit charge the mincap and maxcap fields should be available only when above parameters are selected

Let me know if you have any questions Note: no Mincap and Maxcap value setting for client type of charges from backend.

PC-11-00 commented 8 months ago

Thanks @bharathcgowda For giving the info, I will work on it.

PC-11-00 commented 8 months ago

It is resolved,