openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.

https://openmf.github.io/web-app/

Mozilla Public License 2.0

228 stars 516 forks source link

Fix-environment-variables-running-in-docker #2084

Closed MageziArthur closed 4 months ago

MageziArthur commented 5 months ago

Description

Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.

Related issues and discussion

{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] If you have multiple commits please combine them into one commit by squashing them.
[ ] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

IOhacker commented 4 months ago

@MageziArthur Are you still working on this? Please check the last PR 2095. Change the name about the "docker" part, this PR not only impacts docker also any other distribution.

@terencemo FYI

MageziArthur commented 4 months ago

This is noted @IOhacker, I'll open another pull request