openMF / web-app

Mifos X Web App is the revamped version of the Mifos X Community App built on top of the Fineract Platform leveraging the popular Angular framework.
https://openmf.github.io/web-app/
Mozilla Public License 2.0
228 stars 516 forks source link

Fixes double colon issue in baseApiUrl #2095 #2098

Closed terencemo closed 4 months ago

terencemo commented 4 months ago

Description

As per the documentation here[1], window.location.protocol includes the colon ("http:", "https:") but in generating baseUrl, '://' is used resulting in double colon. This causes login failure due to wrong URL generated in some browsers.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

[1] https://www.w3schools.com/jsref/prop_loc_protocol.asp

terencemo commented 4 months ago

@alberto-art3ch kindly review