search

openMF / web-self-service-app

Web app for clients to access and directly interact with their own accounts using Apache Fineract Self-Service APIs
http://openmf.github.io/web-self-service-app/
MIT License
33 stars 107 forks source link

Addresses #47: Review Button Added for Beneficiary #139

Closed jonathanzhang53 closed 5 years ago

jonathanzhang53 commented 5 years ago

Addresses Issue #47 for GCI Task.

Description

I added a Review button when adding a beneficiary. It shows all the details of the beneficiary before the user clicks Add Now to confirm.

File Changes:

  1. app/global-translations/locale-en.json
    • Changed the button value of Add Beneficiary to Review Beneficiary
  2. app/src/beneficiaries/beneficiaries-add/beneficiaries-add.component.js
    • Added mdDialog and filter to controller parameters and removed rootscope
    • Rerouted submit style button to open up a dialog
    • Tweaked code and eliminated a blank line
  3. app/src/beneficiaries/beneficiaries-add/beneficiaries-add.html
    • Changed the submit button from Add Beneficiary to Review Beneficiary
  4. .../beneficiaries-add/review-beneficiary-dialog/review-beneficiary-dialog.component.js
    • Copied format of review-transfers-dialog.component.js
    • Added a function to parse accountType.id to its actual value (1: Loan Account; 2: Savings Account)
  5. .../beneficiaries/beneficiaries-add/review-beneficiary-dialog/review-beneficiary-dialog.html
    • Copied format of review-transfers-html
    • Changed data values that appear

Screenshots/GIFs, if any:

beneficiary