search

openMSL / sl-1-0-sensor-model-repository-template

Template repository: Clone and build your ASAM OSI sensor model.
Mozilla Public License 2.0
8 stars 2 forks source link

Logging does not seem to work #69

Closed ClemensLinnhoff closed 1 year ago

ClemensLinnhoff commented 1 year ago

Describe the bug: OSMP Logging functions cannot be enabled.

MarcelKe commented 1 year ago

  1. The PRIVATE_LOGGING flag in the OSMPConfig.in.h might miss: image

  2. I guess it would be nice to copy the resulting OSMPConfig.h with the other source files to the build folder:

image

(diffferent name in my local fix)

ClemensLinnhoff commented 1 year ago

  1. I think the PRIVATE_LOGGING flag is not needed in that file. It is set in the CMakeLists. This also aligns with the OSMPDummySensor example.

  2. I added the Config header to the FMU sources.

MarcelKe commented 1 year ago
  1. My bad, I just saw that the PRIVATE_LOGGING flag is only used in the CMakeLists and not in the code itself - The code only checks whether a private logging path is defined.
  2. I can confirm that private logging is working now.