openMSL / sl-1-0-sensor-model-repository-template

Template repository: Clone and build your ASAM OSI sensor model.
Mozilla Public License 2.0
8 stars 2 forks source link

Replace OSI Fieldcheck with OSI-Validation #74

Closed jdsika closed 3 months ago

jdsika commented 7 months ago

Release is out: https://github.com/OpenSimulationInterface/osi-validation

ClemensLinnhoff commented 6 months ago

I suggest, that OSI validation should run on every test (integration and behavior). So as soon as an input trace file is used in a test, osi-validation shall automatically check it against the input. And as soon as an output trace file is generated by a test, osi-validation shall automatically check it against the output rules. So OSI validation becomes sort of a meta test of every test.

Therefore, I will wait with the implementation for https://github.com/openMSL/sl-1-0-sensor-model-repository-template/pull/77 to be merged. Then I will directly implement it for both CL2 and CL3 tests.

ClemensLinnhoff commented 6 months ago

Idea: 3 kinds of rule sets:

  1. Official ASAM rules
  2. Repository rules, one set for input data, one set for output data
  3. Test rules: rules that are specific to a certain test

The official ASAM rules are auto-generated by osi-validation

The repository rules shall be defined for the input and output and put in the doc folder alongside a requirements description.

Individual test rules shall be placed in the corresponding test folder. The pipeline shall automatically detect the rules folder for a test and run osi-validation on the test results with the defined rules.