openMSL / sl-1-0-sensor-model-repository-template

Template repository: Clone and build your ASAM OSI sensor model.
Mozilla Public License 2.0
8 stars 2 forks source link

Add osi-validation to CL2 and CL3 #82

Closed ClemensLinnhoff closed 3 months ago

ClemensLinnhoff commented 3 months ago

Reference to a related issue in the repository

74

Add a description

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

ClemensLinnhoff commented 3 months ago

There seems to be a bug in OSI Validation, see https://github.com/OpenSimulationInterface/osi-validation/issues/78

ClemensLinnhoff commented 3 months ago

Waiting for https://github.com/OpenSimulationInterface/osi-validation/pull/79 to be merged.

jdsika commented 3 months ago

Waiting for OpenSimulationInterface/osi-validation#79 to be merged.

merged

github-actions[bot] commented 3 months ago

Cpp-Linter Report :warning:

Some files did not pass the configured checks!

clang-tidy reports: 1 concern(s) - **src/MySensorModel.cpp:17:25:** warning: [[cppcoreguidelines-avoid-non-const-global-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.html)] > variable 'private_log_file' is non-const and globally accessible, consider making it const ```cpp ofstream MySensorModel::private_log_file; ^ ```

Have any feedback or feature suggestions? Share it here.