search

openMSL / sl-1-2-reflection-based-lidar-object-model

SETLevel: OSI / FMI compliant radar or lidar sensor system model, depending on parametrization.
Mozilla Public License 2.0
15 stars 1 forks source link

404 error when following OSI submodule link #17

Closed PhRosenberger closed 1 year ago

PhRosenberger commented 1 year ago

Describe the bug: When I click on the OSI submodule at https://github.com/openMSL/sl-1-2-reflection-based-lidar-object-model/tree/main/lib, I get an 404 error. Should we probably change the submodule to the last commit of the SETLevel OSI main branch under https://gitlab.setlevel.de/open/osi?

ClemensLinnhoff commented 1 year ago

This is odd. It already points to the last commit of https://gitlab.setlevel.de/open/osi. At least the commit ID and the url in .gitmodules match. But I will check this on a branch.

ClemensLinnhoff commented 1 year ago

I just checked. When I locally pull the main branch in lib/open-simulation-interface, nothing happens. So it is already the current commit of the main branch of SETLevel OSI. I don't know why the link from the GitHub page does not work. But it also doesn't work for eigen (pointing to a GitLab) repository. So probably GitHub just does not link to GitLab.

So can we close this issue @PhRosenberger ?

PhRosenberger commented 1 year ago

Oh ok, so it's more about GitHub not liking GitLab..