openMSX / debugger

31 stars 15 forks source link

adding MacOS build to workflow #144

Closed pvmm closed 1 year ago

pvmm commented 1 year ago
pvmm commented 1 year ago

Here is how it looks like: https://github.com/pvmm/debugger/releases/tag/nightly

MBilderbeek commented 1 year ago

The Actions say: Invalid workflow file: .github/workflows/build.yaml#L10 error parsing called workflow ".github/workflows/build.yaml" -> "./.github/workflows/workflow-build.yaml" : failed to fetch workflow: workflow was not found.

I guess you're still working on it. Let me know when you're done please. I suppose all actions should be running successfully before we want to merge ;-)

pvmm commented 1 year ago

No, it's done. GA complains it cannot find a workflow that is no longer valid because it was replaced. I don't know why the old job scheduler (which should have been replaced) is trying to call an old workflow (which was also replaced), it's weird. But at least if it doesn't work, we can always revert it.

pvmm commented 1 year ago

I tried doing a two step update keeping the old workflow file around, but it doesn't work because GA doesn't consider the intermediate step. I would have to break it into two PRs.

MBilderbeek commented 1 year ago

Without having me to read all the yml files... can you summarize what was output before your changes and what is now output after your changes? Especially because of the thing you said about keeping the old file around. I don't really understand what you said about 'the intermediate step'.

pvmm commented 1 year ago

I returned the commit to how it was before (first version of this PR).

When you commented about the error message, I tried to break it into two commits in the same PR, keeping the old workflow-build.yaml around (and only deleting it on the second commit) because the old job schedule seems to require it , but that didn't work since Github action will not try to build intermediate steps, so it just does the same thing again.

MBilderbeek commented 1 year ago

OK, I will merge it, let's see what happens.