The feature no one asked for: qt6 and cmake migration

samsaga2 commented 1 year ago

The title is self explanatory 😂

samsaga2 commented 1 year ago

I can see that I have to try to update github workflow.

m9710797 commented 1 year ago

Hi samsaga2,

Thanks a lot for your PR!

First some general remarks:

I think we should indeed migrate away from our own Makefile-based build system to a more modern build system. And "cmake" seems to be the de-facto standard.
Personally I don't know much about build-systems. mthuurne setup the build system for openMSX and for the openMSX-debugger. So i'll also leave it up to mthuurne to ack this PR.
Note that this openmsx-debugger is no longer actively developed. The plan is to have a debugger integrated in openMSX itself for the next release (openMSX-19 was released yesterday, next openMSX release is probably a year away).

Now some more specific remarks about the PR itself:

You have this line in the README file: Qt6_DIR=~/Qt/6.6.0/gcc_64 cmake .. -G Ninja. This assumes Qt is installed in the home dir. That's not where typical users will have it installed. And is this manually setting Qt6_DIR required at all? I don't know how find_package(Qt6 ...) behaves in cmake. Can you explain?
Your PR also makes a lot of changes in the cpp files. Are these to fix compiler warnings? Are these because you're using a newer Qt version? Or Both? In any case, I think it would be better to not do both changes at once (make -> cmake migration and Qt version upgrade). Can you split your PR in two parts?

@mthuurne: Can you also comment?

Thanks.

samsaga2 commented 1 year ago

Thanks for your reply. I don't know about the integrated debugger thing. I'm going to close this pull request.

openMSX / debugger