[Bug] ROM type history reset to AUTO when selecting the same ROM [sf#261]

openMSX-import commented 9 years ago

Reported by manuelbi on 2007-03-20 22:22 UTC When you select the same ROM in the history as the one that is currently selected, the ROM type is set to AUTO. When you select it again, it is set to the type you selected before. Small bug, but it's good to document it.

Before BiFi checked in SessionPage.cpp, 1.83->1.84 and SessionPage.h, 1.36->1.37, it was broken much worse: ROM type history was completely broken (always set to AUTO).

This happened when I tried to fix crashes that happened when selecting the same ROM as was already selected from the history box.

Ah well, let's move on to the new Catapult.

openMSX-import commented 9 years ago

Commented by manuelbi on 2008-01-04 21:49 UTC Logged In: YES user_id=78178 Originator: YES

This is a bug in the old Catapult, which isn't maintained anymore, so we won't fix old bugs in it. Closing...

openMSX-import commented 9 years ago

Updated by manuelbi on 2008-01-04 21:49 UTC

status: open --> closed-wont-fix

openMSX-import commented 9 years ago

Commented by joxy on 2013-07-24 07:04 UTC I failed to reproduce this bug. Could you write a thorough test case for it?

openMSX-import commented 9 years ago

Commented by joxy on 2013-07-24 07:16 UTC It seems you assume that the ROM type should not be reset when you selected a new romfile.

It seems that catapult application assumes that the romtype should be selected AFTER romfile selections. This is IMHO a wrong assumption, and I propose a new dialog for the ROM file selection. My proposal is as follows.

We remove the menu item "Select cartridge type (...)" from a "Cart A/B" buttons' menus.
Instead, we design a new "ROM specification" dialog with a "Browse..." (for file) button and a combobox labeled "ROM type:", and with OK/Cancel buttons.
This dialog should be called from a current "Browse..." button in the Session tab (the button which currently has a board icon).
The rom file name line edit field in the Session tab is to be replaced by a non-editable one.

I could implement this dialog. What do you think?

openMSX-import commented 9 years ago

Commented by joxy on 2013-07-24 07:17 UTC

Additionally, Cart A/B's menu item "Browse ROM image" would call this dialog, and should be renamed to "Set up a ROM image".

openMSX-import commented 9 years ago

Commented by joxy on 2013-07-24 07:19 UTC Otherwise, what is your proposal to fix this issue?

openMSX-import commented 9 years ago

Commented by manuelbi on 2013-07-27 20:20 UTC I expected that Catapult would remember the ROM type I selected previously for the same ROM file and not set it back to AUTO. Actually, selecting it again sets it to the remembered ROM type, apparently.

I haven't tried to reproduce this again, but it's a matter of:

select ROM X and set it to rom type A
select ROM Y and set it to rom type B
use the history to select ROM X again. It should show rom type A.
repeat previous step. Possibly you have to have ROM X twice in the history to reproduce this.

Anyway, this bug is not important, so let's not waste time on it.

openMSX-import commented 9 years ago

Updated by manuelbi on 2013-07-27 20:22 UTC

labels: Catapult --> wxCatapult
Group: --> Next_release

openMSX-import commented 9 years ago

Updated by manuelbi on 2013-07-27 20:22 UTC

Group: Next_release --> Postpone_until_after_next_release

openMSX / wxcatapult

[Bug] ROM type history reset to AUTO when selecting the same ROM [sf#261] #12