[Bug] wxCatapult build system: --version and About should automatically show git commit id or output of "git describe", if a current commit is not tagged with not RELEASE_* tag [sf#482]

openMSX / wxcatapult

23 stars 4 forks source link

[Bug] wxCatapult build system: --version and About should automatically show git commit id or output of "git describe", if a current commit is not tagged with not RELEASE_* tag [sf#482] #15

Closed openMSX-import closed 9 years ago

openMSX-import commented 9 years ago

Reported by joxy on 2013-07-30 03:25 UTC Currently, they emit the release string only, for git versions.

openMSX-import commented 9 years ago

Commented by joxy on 2013-07-30 03:25 UTC

Description has changed:

Diff:


--- old
+++ new
@@ -0,0 +1 @@
+Currently, they emit the release string only, for git versions.

openMSX-import commented 9 years ago

Commented by manuelbi on 2013-07-30 18:30 UTC That's because 'release flag' is on 'true'. Then only the release name is given. If you set it to 'false' (both in version.py and version.mk) it will also include the revision number in the user visible version info. That's on purpose. Please close this bug if you can confirm that this is what you meant.

openMSX-import commented 9 years ago

Updated by joxy on 2013-08-02 09:00 UTC

summary: wxCat.: --version and About should show git commit id or output of "git describe", if not RELEASE* tag --> wxCatapult build system: --version and About should automatically show git commit id or output of "git describe", if a current commit is not tagged with not RELEASE* tag

openMSX-import commented 9 years ago

Commented by joxy on 2013-08-02 09:01 UTC Manuel: we need more discussion.

openMSX-import commented 9 years ago

Commented by manuelbi on 2013-08-02 19:43 UTC Usually, we keep the release flags on "False" during development. So, all development builds show the revision. When we actually release, we set the flag on "True", so that the version is completely clean, it just shows the actually released version. That's fine.

But since we stopped developing wxCatapult, we left the release flags on "True". Now that people are working again on this code, we should probably change the flags to "False" again, until we actually release the code again.

openMSX-import commented 9 years ago

Commented by manuelbi on 2013-08-05 21:07 UTC So, feel free to put them on "True" and then I propose to close this bug. (It's not a bug, it's intended behaviour.)

openMSX-import commented 9 years ago

Commented by joxy on 2013-08-07 08:34 UTC Maybe I'll study Python a bit and implement this, so that the flag will be auto-detected from git tags... So let it stay for now

openMSX-import commented 9 years ago

Updated by manuelbi on 2014-02-22 10:12 UTC

status: open --> closed-wont-fix
Priority: 9 --> 3

openMSX-import commented 9 years ago

Commented by manuelbi on 2014-02-22 10:12 UTC I don't think we're going to change this (for now).