search

openMVG / openMVG

open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.
Mozilla Public License 2.0
5.58k stars 1.66k forks source link

Maybe its necessary to extend the openMVG_main_geodesy_registration_to_gps_position? #1795

Open Techhooli opened 3 years ago

Techhooli commented 3 years ago

At first, I must say that openMVG is an excellent tool to finish 3D reconstruction from images. I want to know if there is a method to transform the coordinate system to one defined coordinate system (maybe defined local coordinate system). I have found the GCP registration. But if I only transform the coordinates of the camera centers. The openMVG_main_geodesy_registration_to_gps_position can only transform to ECEF coordinate system？ It doesn't work when I want to use the UTM coordinate system (also derived from GPS). Moreover, if I fixed the cameras on one stable holder. I can calculated the accurate coordinates of camera centers by stereo calibration. So these coordinates will be known in local coordinate system. Maybe it's necessary to extend the openMVG_main_geodesy_registration_to_gps_position in UTM coordinate system or local coordinates system.

pmoulon commented 3 years ago

Thank you for your feedback.

By default the binary support only ECEF https://github.com/openMVG/openMVG/blob/develop/src/software/Geodesy/registration_to_exif_gps_position.cpp#L129 but we do have the code for UTM, feel free to make a PR that will add the coordinate change.

See here for the logic https://github.com/openMVG/openMVG/blob/develop/src/software/SfM/main_SfMInit_ImageListing.cpp#L188

pmoulon commented 3 years ago

@Techhooli Can you help us and make a PR to add the UTM as an option for the binary?

qingzhengzhuma commented 2 years ago

I can do that~