openMVG / openMVG

open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.
Mozilla Public License 2.0
5.66k stars 1.67k forks source link

openmvg2colmap #2180

Open zhangkun788 opened 1 year ago

zhangkun788 commented 1 year ago

The image point coordinates of colmap start from 0.5. The conversion taken into account here?

pmoulon commented 1 year ago

Colmap and openmvg camera model should align

zhangkun788 commented 1 year ago

Camera model alignment is required, but the origin of the image coordinate system of openmvg and colmap is inconsistent ! colmap extracts feature points: FeatureKeypoint(vl_keypoints[i].x + 0.5f, vl_keypoints[i].y + 0.5f, vl_keypoints[i].sigma, angles[o]);

pmoulon commented 1 year ago

May I ask why you want to use colmap. If it is for MVS I would advise you to use OpenMVS.

Regarding key point offset feel free to help. I would advise you to compute reprojection error and see if things align between the OpenMVG and colmap scene. As far I'm aware the OpenMVG2Colmap does not export 2d points positions.