Allow control points to be optimized

openMVG / openMVG

open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.

Mozilla Public License 2.0

5.56k stars 1.66k forks source link

Allow control points to be optimized #2294

Open jvanvugt opened 4 months ago

jvanvugt commented 4 months ago

Adds an option to the Control_Point_Parameter struct to enable optimization of control points in BA, defaults to false so behavior is unchanged.

pmoulon commented 4 months ago

@jvanvugt thank you for the pull request. Do you have any examples to share to show how much your control points changed during the process?

jvanvugt commented 4 months ago

In my use case, I'm detecting fiducial markers in images and adding them as control points after doing a regular reconstruction. They are triangulated with TriangulateNViewAlgebraic and then I run BA to minimize the geometric error. I'm not sure how much the points still move but it would be the difference between the algebraic and geometric error.