search

openMetadataInitiative / bids2openminds

A tool to generate openMINDS metadata from BIDS datasets
MIT License
1 stars 3 forks source link

Adding thorough testing #38

Closed Peyman-N closed 5 months ago

Peyman-N commented 6 months ago

Adding thorough testing based on a curation of a example BIDS dataset.

Peyman-N commented 6 months ago

The collection doesn't contain any File nodes. I guess that hasn't been implemented yet?

The testing approach using detect_type, etc. is fine for now, but it would be better in the medium term to add __eq__ methods to Node and Collection in openMINDS, then the test could just be assert referenceCollection == generatedCollection

Completely agreed, I think this is seems necessary. I would try to tackle it after the first release of bids2openminds.