openMetadataInitiative / openMINDS_SANDS

A metadata model capturing Spatial Anchoring of Neuroscience Data Structures, including brain atlas definitions.
MIT License
12 stars 11 forks source link

add "keyword" category to all atlas elements #258

Open lzehl opened 1 year ago

lzehl commented 1 year ago

@aeidi89 could you take this over or do you need help with this?

UlrikeS91 commented 6 months ago

Looking (slowly but steadily) trough issues and PR. I can fix this one, but it would be great to agree on which elements are meant.

schema keyword? argument
annotation no concept schema & atlas annotation should not get the category
atlas annotation no only ever embedded
brain atlas yes
brain atlas version yes
common coordinate space yes?
common coordinate space version yes?
parcellation entity yes
parcellation entity version yes
parcellation terminology no only ever embedded
parcellation terminology version no only ever embedded

Does that make sense? And what about the non-atlas elements?

schema keyword? argument
customAnatomicalEntity yes?
custom annotation no?
custom coordinate space no?
lzehl commented 6 months ago

I need more context. I do not understand what is meant here

lzehl commented 6 months ago

do you mean you want to have e.g. the term "brain atlas" as a structured keyword for other datasets or do you want to have e.g. "WHSSD Atlas" as potential keyword?

The latter I would not like to support. The purpose / usage of atlas elements should be defined through "inputData" for BAs, BAVs, CCSs, CCSVs,in DSVs or through study targets for PEs, CAEs, or PEVs. For the first we can discuss how to register this best.

UlrikeS91 commented 6 months ago

I just interpreted the issue, no request from my side for anything specific. The way I understood this issue was that all atlas schemas should receive this:

{
  "_categories": [
    "keyword"
  ]
}

I this is not what was meant, I need some more information. But if that is what was meant, I was trying to figure out which atlas schemas should in fact receive the category.

Does that make more sense?

lzehl commented 6 months ago

If that was the suggestion then I would disagree with adding this category to any atlas schemas or at least would like to further discuss this.