openMetadataInitiative / openMINDS_controlledTerms

Metadata model for the consistent registration of well-defined terms as well as a corresponding library of terminologies (including links to ontological terms where applicable).
MIT License
7 stars 12 forks source link

Request for Stimulation Artifact Correction registered as technique #361

Closed maciej-jedynak closed 5 months ago

maciej-jedynak commented 1 year ago

Metadata for the F-TRACT dataset will need a Stimulation Artifact Correction to be registered as a Technique. It sounds very general, but the reference describing details, is the following one: http://dx.doi.org/10.1016/j.jneumeth.2016.03.002

lzehl commented 1 year ago

@maciej-jedynak thank you for the term suggestion. We will add it to the techniques. Based on the article I hope you agree that it would make sense to call this technique "model-based stimulation artifact correction" (vs. the average-based stimulation artifact correction.

lzehl commented 1 year ago

@apdavison I already committed the new technique by accident. Could you review the RAW file to make sure that I defined it correctly: https://raw.githubusercontent.com/HumanBrainProject/openMINDS_controlledTerms/v1/instances/technique/modelBasedstimulationArtifactCorrection.jsonld

lzehl commented 1 year ago

NOTE: correct instance; add also "stimulation artifact correction" as super-class and "average-based artifact correction" as additional method.

Peyman-N commented 1 year ago

It seems good to me :)

apdavison commented 1 year ago

In the @id, "modelBasedstimulationArtifactCorrection" should probably be "modelBasedStimulationArtifactCorrection".

lzehl commented 1 year ago

@apdavison thanks for spotting this. I will correct it with the PR for moving all analysis techniques from Technique to AnalysisTechnique terminology