Cleanup of categories and adding of AnalysisTechnique

openMetadataInitiative / openMINDS_controlledTerms

Metadata model for the consistent registration of well-defined terms as well as a corresponding library of terminologies (including links to ontological terms where applicable).

MIT License

7 stars 12 forks source link

Cleanup of categories and adding of AnalysisTechnique #393

Closed lzehl closed 1 year ago

lzehl commented 1 year ago

adding category "anatomicalLocation" to: CellType, Organ, OrganismSubstance, SubcellularEntity, UBERONParcellation
adding category "technique" to: AnalysisTechnique, StimulationTechnique, Technique
adding new schema AnalysisTechnique
adding new instance for Terminology ("analysis technique")
adding one instance for AnalysisTechnique

lzehl commented 1 year ago

@UlrikeS91 I hope I've got everything.

UlrikeS91 commented 1 year ago

@UlrikeS91 I hope I've got everything.

Yes and no, you had everything before I noticed that my list was missing something 😆

Would you mind adding the new terminology LivePaperSectionType to this PR? Details are described in https://github.com/HumanBrainProject/openMINDS_publications/pull/12 and I added it to my sheet as well (if you want to add the PR reference as you did for all the other ones).

lzehl commented 1 year ago

@apdavison I need your input / feedback for the new controlled terms for LivePaperSectionType:

xxxSection or xxxPaperSection or xxxLivePaperSection ??
customXXX definition: "A 'custom XXX' is used to describe custom elements within a live paper." ??
genericXXX definition: "A 'generic XXX' is used to describe generic elements within a live paper." ??
modelXXX (or computationalModelXXX ?) definition: "A 'model XXX' is used to describe a model element within a live paper." ??
morphologyXXX (or neuronMorphologyXXX ?) definition: "A 'morphology XXX' is used to describe a morphology element within a live paper." ??
traceXXX (or neuronalTraceXXX ?) definition: "A 'trace XXX' is used to describe a trace element within a live paper." ??

apdavison commented 1 year ago

Hi @lzehl - please remove the controlled terms for LP section types.

lzehl commented 1 year ago

@apdavison & @UlrikeS91 LivePaperSectionTypes are removed from this PR (based on decision in cf. https://github.com/HumanBrainProject/openMINDS_publications/pull/12#issuecomment-1446214026)

lzehl commented 1 year ago

@aeidi89 feel free to merge if you approve this PR now (@apdavison concerns were addressed)

lzehl commented 1 year ago

@aeidi89 no that definition does not make sense. It is way too specific. An 'analysis technique' refers to any mathematical analysis applied to any type of data.

I will add definitions for all terminologies later on (none of them have one at the moment). I think we should do this in a separate PR.

aeidi89 commented 1 year ago

@lzehl Thank you for explaining, the ward clustering makes more sense then as well. I'll merge and close this PR.