search

openMetadataInitiative / openMINDS_controlledTerms

Metadata model for the consistent registration of well-defined terms as well as a corresponding library of terminologies (including links to ontological terms where applicable).
MIT License
7 stars 12 forks source link

"TermSuggestion" is not really a "controlledTerm" #449

Open olinux opened 1 year ago

olinux commented 1 year ago

Whilst updating the ingestion mechanism, I figured out one inconsistency in "controlledTerms" - the "TermSuggestion" is (by definition) not really a "controlledTerm" but its instances are supposed to be dynamic. I'm therefore wondering if it shouldn't be moved towards "core".

https://github.com/HumanBrainProject/openMINDS_controlledTerms/blob/0f6c0fa912fd40fe560a3e419fc88524ef7454d2/schemas/termSuggestion.schema.tpl.json#L2

lzehl commented 1 year ago

@olinux I actually think "controlledTerm" is a poor naming from our side at the beginning. In principle this repository (and the connected schema types) should be renamed to "terms" or to "terminologies". This is a huge change though which I'm not sure we want to introduce now. Your thoughts?

lzehl commented 1 year ago

openMINDS dev meeting decision: we should better document this odd schema for now and discuss changing the name of the "controlledTerms" to "terms" or "terminologies" for a new major release of openMINDS.