openMetadataInitiative / openMINDS_core

The openMINDS core metadata model includes schemas that can be used to describe the general origin, location and content of research products.
MIT License
20 stars 19 forks source link

Inconsistencies with _extends values #511

Open Raphael-Gazzotti opened 2 months ago

Raphael-Gazzotti commented 2 months ago

Paths should start with the “/” character or without. But we should not see both cases.

Non-exhaustive examples: (Sample of schemas in openMINDS_SANDS)

Sample of “schemas/atlas/atlasAnnotation.schema.tpl.json”

{ 

  "_type": "https://openminds.ebrains.eu/sands/AtlasAnnotation", 

  "_extends": "atlas/annotation.schema.tpl.json", 

... 

Sample of “schemas/atlas/brainAtlas.schema.tpl.json”

{ 

  "_type": "https://openminds.ebrains.eu/sands/BrainAtlas", 

  "_extends": "/core/schemas/products/researchProduct.schema.tpl.json",
...
apdavison commented 2 months ago

The concept is that paths starting with "/" are absolute paths, used to refer to schemas in other repositories (i.e. other sub-modules), while paths without "/" are relative to the current repository/submodule.

We could make all paths absolute, but I don't see the current usage as inconsistent.