search

openMetadataInitiative / openMINDS_documentation

Read-The-Docs documentation for the openMINDS metadata framework.
MIT License
0 stars 2 forks source link

CommonCoordinateSpaceVersion link to CommonCoordinateSpace #23

Closed bendichter closed 7 months ago

bendichter commented 7 months ago

Unless I am reading this wrong (which is certainly possible) it looks like you have a CommonCoordinateSpaceVersion spec and a CommonCoordinateSpace spec but there is no linkage between the two. I propose adding a is_version_of attribute to CommonCoordinateSpaceVersion pointing to a CommonCoordinateSpace.

ehennestad commented 7 months ago

If you look at the CommonCoordinateSpace schema in the SANDS model, it has a hasVersion property:

https://github.com/openMetadataInitiative/openMINDS_SANDS/blob/3a542916b22c0b8f4b6dd64c4bba1658614bf78b/schemas/atlas/commonCoordinateSpace.schema.tpl.json#L32-L39

Links in the openMINDS schemas are typically one-directional, and then graph databases can implement reverse links for instances. Lyuba can fill inn more details on this!

apdavison commented 7 months ago

@ehennestad just beat me to it, but since I just finished typing this I'll post it anyway!

There is an explicit hasVersion link from CommonCoordinateSpace to CCSV: https://openminds-documentation.readthedocs.io/en/latest/schema_specifications/SANDS/atlas/commonCoordinateSpace.html#hasversion

There is an implicit reverse link, which we haven't formally named (naming reverse links is still a TODO), although fairgraph does indeed use the name is_version_of as you suggest.

bendichter commented 7 months ago

ok cool, thanks!