search

openMetadataInitiative / openMINDS_ephys

A metadata model for capturing in-depth descriptions of electrophysiology experiments.
MIT License
4 stars 5 forks source link

Array schema feedback #21

Closed UlrikeS91 closed 2 years ago

UlrikeS91 commented 2 years ago

1) "_type" missing 2) Looks like this is related to https://github.com/HumanBrainProject/openMINDS_core/issues/189, isn't it? This is not specifically important for v0, but we may want to fix this properly soon ☺️ 3) I'm a little confused by this schema, could you explain the purpose? An example I'm confused by is unit and timeUnit: Are these related to valueVector and timeVector, respectively? That would be kind of strange since QV/QVR has value & unit. Same goes for the additional uncertainity and typeOfUncertainity. 4) I actually couldn't find a schema this was used in. Is it used anywhere?

Peyman-N commented 2 years ago

@UlrikeS91 Sorry my bad, I have forgotten to delete it :sweat_smile:

This used to be another possibility for the value property of the Measurement. But after discussion with @apdavison we decided against it.

I'm a little confused by this schema, could you explain the purpose?

The goal was to register a small array of measurements (or any time series in general)

An example I'm confused by is unit and timeUnit: Are these related to valueVector and timeVector, respectively?

Yes, exactly.

That would be kind of strange since QV/QVR has value & unit. Same goes for the additional uncertainity and typeOfUncertainity.

Agreed if we ever want to use these we should change their type to number, they can't be QuantitativeValue