openMetadataInitiative / openMINDS_ephys

A metadata model for capturing in-depth descriptions of electrophysiology experiments.
MIT License
4 stars 5 forks source link

Device & Pipette schema feedback #23

Closed UlrikeS91 closed 2 years ago

UlrikeS91 commented 2 years ago

Device

property feedback
deviceType -
internalIdentifier -
manufacturer We used "vendor" in the StockNumber schema (used in the "Strain" schema) pointing to an "core/Organization". Wouldn't that make sense here to? So, pointing to "core/Organization" not the "vendor" part šŸ˜†
modelName -
serialNumber -
description -
software Isn't this weird in combination with devices that cannot have a software? Like electrodes or pipettes?
parameterSet change according to https://github.com/HumanBrainProject/openMINDS_core/issues/322

"Manufacturer" and "modelName" should maybe be optional, e.g. custom-made pipettes cannot fulfill this criterion.

Pipette

apdavison commented 2 years ago

"manufacturer": good idea. Should probably be Organization or Person.

"software": do you have any suggestions? We could have an extension ElectronicDevice? (we also need to revisit the HardwareSystem schema in the computation module, which overlaps with this).

UlrikeS91 commented 2 years ago

"manufacturer": good idea. Should probably be Organization or Person.

Yeah, you can use category "LegalPerson". Then you get both. We didn't do that for the "StockNumber" schema because it seemed wrong to assume that single persons would provide stock numbers. But for a manufacturer, why not.

"software": do you have any suggestions? We could have an extension ElectronicDevice? (we also need to revisit the HardwareSystem schema in the computation module, which overlaps with this).

Yeah, your idea sounds pretty good. Have a device schema that fits any kind of device and then extend this with other schemas for more specialized categories. "ElectronicDevice" could be for amplifiers and such. This could get the property "software". "Probe" (or similar) could be for pipettes and electrodes (and others in the future, like a biopsy tool) . But only if there are properties that would specifically apply to those. Otherwise, they just extend the "device" schema then.