openMetadataInitiative / openMINDS_ephys

A metadata model for capturing in-depth descriptions of electrophysiology experiments.
MIT License
4 stars 5 forks source link

Clean up: electrode array usage #42

Closed UlrikeS91 closed 1 year ago

UlrikeS91 commented 1 year ago

MINOR changes:

MAJOR changes:

SPECIAL ATTENTION:

Peyman-N commented 1 year ago

This pull request should only be merged after the concept schema has been added to core. (#454)

lzehl commented 1 year ago

@UlrikeS91 @Peyman-N @apdavison maybe we should split the location property in two then? one asking for the overall location of the entire array the other for the individual location of the electrodes ?

OR should overall location be simply covered by the placement activity?

lzehl commented 1 year ago

@Peyman-N and @apdavison I need feeback to fix this:

Generally speaking we do have an ElectrodePlacement activity which would define the target position of the array.

option a) we ask separately here for the following properties:

option b) we ignore the overall location of the array (if only a general location is know it has to be repeated for each used electrode); keeping only the properties

I think I prefer option b. What about you?

Peyman-N commented 1 year ago

I prefer option b too.

lzehl commented 1 year ago

option c) we ask separately here for the following properties:

anatomicalLocationOfElectrodes
anatomicalLocationOfArray (still array ? or only one ? )
spatialLocationElectrodes