Closed ax3l closed 2 months ago
X-ref: #1439 pt. 3
The problem is actually that particle patches are not openPMD records https://github.com/openPMD/openPMD-standard/blob/latest/STANDARD.md#sub-group-for-each-particle-species Update: they are records, in a sub-group.
But the API seems to currently parse it as such, looking for unitDimension
on extent
, offset
, etc.
Fix coming for particle patches example from openPMD-validator via https://github.com/openPMD/openPMD-validator/pull/75 and https://github.com/openPMD/openPMD-example-datasets/pull/23
Describe the bug We recently introduced more graceful error handling when we encounter incomplete data. I found another data set, which we use in openPMD-updater, that only contains structure but no real data in it.
In this data set,
particlePatches
cause read errors inopenPMD-ls
.To Reproduce Download the file
structure.h5
from https://github.com/openPMD/openPMD-example-datasets/pull/22 / https://github.com/openPMD/openPMD-example-datasets/blob/draft/structure.h5Expected behavior Should as it does for the other missing data gracefully skip
Software Environment
Additional context @s-sajid-ali and me are working on 2.0 updates for https://github.com/openPMD/openPMD-updater and moved the little example file in it to https://github.com/openPMD/openPMD-example-datasets via https://github.com/openPMD/openPMD-example-datasets/pull/22