openPMD / openPMD-standard

:notebook: Open Standard for Particle-Mesh Data
http://www.openPMD.org
Creative Commons Attribution 4.0 International
78 stars 27 forks source link

Species Type: Clarifications on Molecule Syntax #261

Open s9105947 opened 2 years ago

s9105947 commented 2 years ago

The current version of the species type extension demands for molecule syntax: "Use standard chemical notation, e.g.: H2O."

What is "standard chemical notation" specifically?

Notable cases:

This is a bottomless hole, so I'd like to suggest as a minimal version:

Note: Depending on if an isotope is also an atom maybe use "atom or isotope" repectively.
Note: Potentially replace the charge separator character.

ax3l commented 2 years ago

The answer for this is similar to https://github.com/openPMD/openPMD-standard/issues/260#issuecomment-1006464841:

We don't have a use case with a committed chemistry code yet and leave this open to the first one(s) that would like to adopt openPMD. I like your suggestion, but would not standardize it until we have a concrete use case/adopter.

Note for the future reader: @s9105947 works on PIConGPU, which is an electromagnetic particle-in-cel code in laser-plasma physics (keV to MeV range physics, while molecules are eV physics and not covered by em. PIC.)

s9105947 commented 2 years ago

In this case I would suggest to remove the paragraph about molecules alltogether:

"The base standard does not encode molecules. However, an implementation MAY support molecules with an implementation-defined syntax."

In my opinion the current "use standard chemical notation" is not sufficiently clear.