search

openPMD / openPMD-yt

[WIP] Reader for yt-project.org (draft)
1 stars 2 forks source link

add __config__.py; *.so and *.c to .gitignore #3

Closed Rahmspinat closed 8 years ago

Rahmspinat commented 8 years ago

add __config__.py ; .so and .c to .gitignore

ax3l commented 8 years ago

I would not ignore *.c files because files such as yt/utilities/data_point_utilities.c seem not to be created at runtime but are necessary source code. Is that correct?

What is the __config__.py file doing? When is it created and where? (It's not in the current source so I guess it's really temporary and fine to ignore.)

*.so files are compiled, shared libraries and not included in the current source, so that is fine.

PrometheusPi commented 8 years ago

@ax3l this should fix the cython problem.

ax3l commented 8 years ago

let us add *.pyo below *.pyc, too (link)

ax3l commented 8 years ago

@PrometheusPi ok, should at least work until the next upstream release ;)

ax3l commented 8 years ago

if you need *.pyo to be ignored at some point just open up a follow-up PR.

well done! :sparkles: