Closed gedankenstuecke closed 7 years ago
I'm getting on this as my first contribution to #mozsprint 2017!
Ok here are some comments starting with the FAQs page for English:
[x] title should say 'What does OpenSNP offer me as a genotyping-customer? ' -> delete the final 's'
[x] first line should say 'If you were genotyped by 23andMe, deCODEme...'
[x] in the third paragraph it sounds more normal to say 'You can also publish some of your phenotypes so, someday, it might be possible to associate some SNPs with phenotypes...' (though 'become' is not actually wrong)
[x] in the Who is behind this? section, you don't need the hyphen between master-progammes in 'Bastian and Philipp did their undergraduate studies in Life Sciences and are currently doing their master-programmes'. It actually sounds more normal to say 'Master's degrees'.
[x] the following line says you are doing your PhDs -> how are you doing your Masters and a PhD at the same time...?
[x] change 'Helge is the only “real” web developer on the team and has helped us a lot in testing many of the things we did.'
[x] in the Why all this? section, change 'openSNP is a non-profit, open-source project that is about sharing genetic and phenotypic information.' -> delete the 'al'
[x] change 'The idea for this project came to Bastian after he was genotyped by 23andMe ...'
[x] change the title 'How much does membership in openSNP cost?' -> delete the 'a'
[x] change 'We take the "open" in openSNP seriously, so everything is free of charge.'
[x] in the Exomes? section change 'If you have had your exome sequenced through 23andMe ...'
[x] in the I was gentoyped by another company... section, change 'If your company is missing up to now it is because we did not have an example-file...' -> delete the comma between 'is' and 'because'
In your README:
[x] under the Contributing to openSNP section it says 'We also have a ROADMAP.md, containing your idea of where the project should head....' -> I am assuming that 'your' should be 'our'?
[x] in the same section, change 'May you be celebrated, inside our humans.txt and outside of it!'
@amiefairs Awesome, thanks so much!
For the markdown files like ROADMAP.md
, INSTALL.md
you can go ahead and do edits on those right away. There will be no (major) conflicts I guess. Just the *.html.erb
are the ones that @philippbayer is overhauling right now. 🙂
The FAQ related items are now part of #365 and will be live with the new page layout. 👍
Okay, he big PR is now merged. Front-end changes can now be directly done through new pull requests. 👍 🎉
Thanks again for all the help. Closed for now. 💖
None of the main contributors to openSNP is a native speaker. So there'll be lots of typos and/or grammatical sins in the texts on our website. Looking through those and fixing them would be great. ❤️