openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process
Other
10 stars 13 forks source link

tests hang on Windows #1

Closed chorny closed 7 years ago

chorny commented 7 years ago

03_func.t:

# Subtest: _new_err
    ok 1
    ok 2
    1..2
ok 1 - _new_err
# Subtest: write_pidfile
    ok 1
    1..1
ok 2 - write_pidfile
# Subtest: _fork
Can't use an undefined value as filehandle reference at lib/Mojo/IOLoop/ReadWriteProcess.pm line 229.
(hangs)

If your module cannot work on Windows at all, you can die in Makefile.PL/Build.PL. See http://wiki.cpantesters.org/wiki/CPANAuthorNotes for how to do this.

mudler commented 7 years ago

Will look at it and try to not ditch support for Windows. But i don't have a machine with Windows to test on it, so in worst case i'll just let it die for windows builds. Thanks for reporting

update: it's only 03_func.t affected?

mudler commented 7 years ago

Can you confirm that after https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess/commit/448f7196d66ef1a42f68506ae8790eefd5d7d835 the test get skipped? thanks

chorny commented 7 years ago

Yes, tests no longer hang. Other tests have non-zero exit code when running Build test, but I don't see any problems when running standalone.

mudler commented 7 years ago

Thanks, when will have spare time will check out test errors that breaks compatibility with Windows systems, maybe setting up AppVeyor would be helpful. Tests currently are meant to be run under Linux/BSD environments (they are even also calling bash scripts).