search

openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process
Other
10 stars 13 forks source link

Avoid executing "blocking stop" code when process has already terminated #13

Closed Martchus closed 4 years ago

Martchus commented 4 years ago

This saves measurably time, e.g. the os-autoinst test t/18-qemu-options.t needs 28 seconds to execute on my system without this change and 11 seconds with this change.

See https://progress.opensuse.org/issues/71110 for the motivation.

okurz commented 4 years ago

I think I was at this point already. At least I am pretty sure I had significantly less than 28 seconds runtime of t/18-qemu-options.t . Anyway, LGTM

codecov-commenter commented 4 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   89.02%   88.93%   -0.09%     
==========================================
  Files          27       27              
  Lines         893      895       +2     
  Branches      202      203       +1     
==========================================
+ Hits          795      796       +1     
  Misses         21       21              
- Partials       77       78       +1
Impacted Files Coverage Δ
lib/Mojo/IOLoop/ReadWriteProcess.pm 90.44% <100.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f6d218...1881749. Read the comment docs.