Match on 'armv7l' as well as 'arm' for prctl detection

openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process

Other

10 stars 13 forks source link

Match on 'armv7l' as well as 'arm' for prctl detection #15

Closed AdamWill closed 3 years ago

AdamWill commented 3 years ago

...as this is what the uname call gives on Fedora's 32-bit ARM builders, at least. Not matching it ultimately leads to the os-autoinst test suite failing on 32-bit ARM package builds.

Signed-off-by: Adam Williamson awilliam@redhat.com

AdamWill commented 3 years ago

Note I'm pretty sure this is correct but I'm still testing. I had to send the PR before running the build test for...reasons...

AdamWill commented 3 years ago

Huh. A build test against the module with this patch applied failed, hard to tell why. But it ought to work. Grr. Don't merge this yet.

AdamWill commented 3 years ago

OK, so, on the whole I think this patch is probably correct but the test is still failing for some other reason. It does make the error we saw at first go away at least.

mudler commented 3 years ago

for the tests: we really should look into switching to GHA, since travis moved to .com seems we lost notifications here