search

openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process
Other
10 stars 13 forks source link

Add test for SIG_CHLD handler in spawned process #30

Closed cfconrad closed 2 years ago

cfconrad commented 2 years ago

During discussion of https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess/issues/29 we realized that a tests like this need to be successful.

The reason for it is, if we use session::protect() when doing the fork() or open3() then the sigmask of the child still has SIGCHLD blocked.

codecov-commenter commented 2 years ago

Codecov Report

Merging #30 (e6cdc91) into master (5faa978) will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   88.82%   88.93%   +0.11%     
==========================================
  Files          27       27              
  Lines         895      895              
  Branches      204      204              
==========================================
+ Hits          795      796       +1     
  Misses         21       21              
+ Partials       79       78       -1
Impacted Files Coverage Δ
lib/Mojo/IOLoop/ReadWriteProcess.pm 90.34% <0.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5faa978...e6cdc91. Read the comment docs.

cfconrad commented 2 years ago

Any reason why we do not take this?