search

openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process
Other
10 stars 13 forks source link

Add mergify configuration #42

Open okurz opened 2 years ago

foursixnine commented 2 years ago

I'd rather hold on to mergify until we have better coverage, or somehow os-autoinst is integrated into the testing (or testing gets better in general)

Martchus commented 2 years ago

@foursixnine We'd still require 2 approvals and no pending reviews.

okurz commented 2 years ago

I'd rather hold on to mergify until we have better coverage, or somehow os-autoinst is integrated into the testing (or testing gets better in general)

Having low coverage didn't stop us or you from merging regression introducing changes in the past ;) I still consider it an important task by human reviewers to approve only after thorough review which should include manual testing as long as further automatic testing does not cover more. This merely codifies rules into automatic executions and also helps in case of trivial things, e.g. everyone tested and approved but there are just simple typos to fix or tidy rules to apply, etc.

okurz commented 2 years ago

tidy rules seem to have updated. I need to do https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess/pull/44 first

okurz commented 2 years ago

Just for the record, it's not that I'm completely against mergify... it's that id prefer that merges happen when we know all is good.

I agree. I just want to give a proper written definition of what "all is good" means to us :)