search

openSUSE / Mojo-IOLoop-ReadWriteProcess

Execute external programs or internal code blocks as separate process
Other
10 stars 13 forks source link

Revert "Enable support for MacOSX (darwin)" #54

Closed foursixnine closed 11 months ago

foursixnine commented 11 months ago

Seems force push was still allowed

This reverts commit fea0105cd5c36657e10886d7e4ebdcde15514db9.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b5799d5) 89.24% compared to head (b77da68) 89.57%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ========================================== + Coverage 89.24% 89.57% +0.33% ========================================== Files 27 27 Lines 902 902 Branches 206 206 ========================================== + Hits 805 808 +3 Misses 21 21 + Partials 76 73 -3 ``` | [Files](https://app.codecov.io/gh/openSUSE/Mojo-IOLoop-ReadWriteProcess/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [lib/Mojo/IOLoop/ReadWriteProcess.pm](https://app.codecov.io/gh/openSUSE/Mojo-IOLoop-ReadWriteProcess/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-bGliL01vam8vSU9Mb29wL1JlYWRXcml0ZVByb2Nlc3MucG0=) | `92.20% <ø> (+1.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

okurz commented 11 months ago

What's wrong with https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess/commit/fea0105cd5c36657e10886d7e4ebdcde15514db9 ?

foursixnine commented 11 months ago

What's wrong with fea0105 ?

Nothing in reality, I just don't like commiting to master (missed the remote when doing a force push)... in the end I think I'll just go ahead and fix the CI and move on with my life

Martchus commented 11 months ago

If there's nothing wrong with that commit I'd say reverting it now clutters the commit history even more so just keep it.

foursixnine commented 11 months ago

I'll follow up on #55