Closed okurz closed 4 years ago
well, that didn't work: https://travis-ci.org/github/mudler/Mojo-IOLoop-ReadWriteProcess/jobs/665023160#L500 shows
t/01_run.t ............... 3/?
# Failed test 'Still able to get stdout output, always in getline()'
# at t/01_run.t line 196.
# got: undef
# expected: 'TEST normal print
# '
# Looks like you failed 1 test of 37.
t/01_run.t ............... 4/?
sigh. Not sure what to do next.
Merging #8 into master will increase coverage by
0.16%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 88.76% 88.92% +0.16%
==========================================
Files 27 27
Lines 881 885 +4
Branches 200 203 +3
==========================================
+ Hits 782 787 +5
+ Misses 21 20 -1
Partials 78 78
Impacted Files | Coverage Δ | |
---|---|---|
lib/Mojo/IOLoop/ReadWriteProcess/Container.pm | 86.36% <0%> (-0.74%) |
:arrow_down: |
lib/Mojo/IOLoop/ReadWriteProcess.pm | 90.68% <0%> (+0.71%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fc64724...262e4fb. Read the comment docs.
Ok, managed to fix all problems, I guess. Thanks to @Martchus for the productive pair-programming session :)
@mudler @foursixnine could you take a look please? All tests are stable now, I improved tests and would appreciate if we can have this patch merged and a new release of the package published.
Done! Thank you!