search

openSUSE / agama

A service-based Linux installer
GNU General Public License v2.0
124 stars 36 forks source link

[web] Stop exporting all components #1049

Open dgdavid opened 4 months ago

dgdavid commented 4 months ago

TL;DR: rewrote namespace/index.js files for exporting only public components

As discussed at https://github.com/openSUSE/agama/pull/1045#discussion_r1497103964, right now we're exporting all components via their namespace's index.js file. However, as @joseivanlopez wrotes, it should export the pages and the components that might be reused from pages out of its namespace. The rest should be considered as internal components.

Instead of start diverging the way it is currently done in a single namespace, I've created this issue for addressing all of them at once.

lslezak commented 1 month ago

Note: exporting everything and using the internal components might cause dependency cycles which break hot module replacement. See related #1214 .