search

openSUSE / branding

openSUSE branding for the distribution - both branding-openSUSE and branding-baseonopensuse
30 stars 40 forks source link

Rename Source Sans Pro to Source Sans 3 #127

Closed dgdavid closed 3 years ago

dgdavid commented 3 years ago

As stated in https://github.com/openSUSE/installation-images/pull/516, adobe-sourcesanspro-fonts changed font names from "Source Sans Pro" to "Source Sans 3". See https://github.com/adobe-fonts/source-sans/issues/192

So, now that new version has arrived at Factory, let's update the .qss files to avoid problems.

Related to

dgdavid commented 3 years ago

@hellcp, https://github.com/openSUSE/branding/blob/tumbleweed/gfxboot/text.svg?short_path=dc44bbb has a lot of ocurrences of Source Sans Pro. Should we update that file too?

hellcp commented 3 years ago

with gfxboot branding, changing the name would actually break the build, since we ship source sans pro font file

dgdavid commented 3 years ago

with gfxboot branding, changing the name would actually break the build, since we ship source sans pro font file

Ok, thanks the for the information.

So, does the PR look good for you as it is?

hellcp commented 3 years ago

Yup, it does, the spec file will need adjusting too, but that shouldn't be too troublesome when submitting this to devel project

jreidinger commented 3 years ago

Is there anything blocking merge or this PR? bug is still opened https://bugzilla.suse.com/show_bug.cgi?id=1188927