search

openSUSE / branding

openSUSE branding for the distribution - both branding-openSUSE and branding-baseonopensuse
30 stars 40 forks source link

Run optipng over pngs #95

Closed hellcp closed 5 years ago

sysrich commented 5 years ago

The reason we stopped doing that in the past was a tendency for optipng to produce different enough pngs that openQA cared and so we kept on having to reneedle just because of a new build

If you are confident this won’t happen, LGTM

hellcp commented 5 years ago

The only part that is checked with openQA from this PR is GRUB, afaik Plymouth and Xfce splash are completely ignored.

sysrich commented 5 years ago

IIRC it was different in the olden times I am referring to.. 👴

coolo commented 5 years ago

It's the first time I hear that optipng changes pngs in a way that is visible at all. All it does is comparing different compression settings - if it changes the resulting pixels, it's a critical bug. Especially as openqa calls optipng on needles you create, it would be very problematic.