search

openSUSE / cepces

cepces is an application for enrolling certificates through CEP and CES.
GNU General Public License v3.0
30 stars 21 forks source link

Fix WSTEP BinarySecurityToken attribute namespaces #30

Closed bmsiegel closed 1 year ago

bmsiegel commented 1 year ago

Signed-off-by: Brady Siegel brsiegel@amazon.com

dmulder commented 1 year ago

@bmsiegel could you explain what this change is doing? Please make the commit message more verbose.

KyleBS commented 1 year ago

The BinarySecurityToken type comes from WSSE: https://docs.oasis-open.org/wss/v1.1/wss-v1.1-spec-errata-os-SOAPMessageSecurity.htm. Under section 6.3.2 you'll see the supported attributes and those attribute's namespaces with the first example being:

<wsse:BinarySecurityToken wsu:Id=...
                          EncodingType=...
                          ValueType=.../>

This pull request drops the namespaces from the EncodingType/ValueType attributes and adds the correct one to the Id attribute. Agreed that this information can be better explained in the commit message so others understand the context of the change.

Presumably this has worked to date because the MS WSTEP implementation has been lax about validating the attribute namespaces.