search

openSUSE / chameleon

openSUSE Design System for Web
https://static.opensuse.org/chameleon/
GNU General Public License v3.0
13 stars 10 forks source link

Don't build wiki into the main stylesheet/js #16

Closed hellcp closed 4 years ago

hellcp commented 4 years ago

The stylesheet and js get a little bit bloated, and add classes that might conflict with other software, it would be good to only build in wiki stylesheet for wikis.

guoyunhe commented 4 years ago

Wiki contains a lot of bento styles. So we added some SaSS extends magic to override them. This part can be do in other way: replace class names with JS.

JS part can be built separately for sure.

hellcp commented 4 years ago

I don't think the fact that sass for it exists is a problem, the problem is that no other website should and hopefully will never use those styles, so they should not exist in a common stylesheet

guoyunhe commented 4 years ago

Rely on https://github.com/openSUSE/wiki/pull/54

guoyunhe commented 4 years ago

This has been fixed in dev branch. Will deploy to static.opensuse.org when heroes have time.